Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #![feature(param_attrs)] to enable exception example #231

Closed
wants to merge 1 commit into from

Conversation

bobgates
Copy link

On rust V1.39 nightly, at least, the exceptions example gives an error. Adding a line to the example allows it to run.

I'm very green at rust embedded, so there may be better ways, but this makes the example work.

On rust V1.39 nightly, at least, the exceptions example gives an error. Adding a line to the example allows it to run.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Mar 25, 2020
@therealprof
Copy link
Contributor

Hi @bobgates, I believe that is a fluke in the nightly build you're using because param_attrs where stabilized around that time, cf. rust-lang/rust#64010.

@bobgates
Copy link
Author

bobgates commented Apr 2, 2020

Okay, with a current Rust nightly 1.44, this problem goes away.

@bobgates bobgates closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants